Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default case to reduce cpu consumption #132

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

andykuszyk-form3
Copy link
Contributor

@andykuszyk-form3 andykuszyk-form3 commented Aug 21, 2023

When running a stage configured loadtest, the agent always take 100% of a core, as there is a spin in a select in the file internal/trigger/file/stages_worker.go .

With this MR, it only tick when there is something to do.

This PR is a copy of the original, but will run the CI in this repo.

@andykuszyk-form3 andykuszyk-form3 requested a review from a team as a code owner August 21, 2023 08:20
@andykuszyk-form3 andykuszyk-form3 changed the title Victorwatrelos fix spin loop reduce cpu Remove default case to reduce cpu consumption Aug 21, 2023
@andykuszyk-form3 andykuszyk-form3 requested review from markhowardform3 and nvloff-f3 and removed request for markhowardform3 August 21, 2023 08:26
@andykuszyk-form3 andykuszyk-form3 force-pushed the victorwatrelos_fix_spin_loop_reduce_cpu branch from fda194f to d66c472 Compare August 21, 2023 09:19
@andykuszyk-form3 andykuszyk-form3 merged commit df366b4 into master Aug 21, 2023
1 check passed
@andykuszyk-form3 andykuszyk-form3 deleted the victorwatrelos_fix_spin_loop_reduce_cpu branch August 21, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants